KeyShot Forum

Technical discussions => General discussion => Topic started by: LM6 on June 23, 2020, 02:10:09 AM

Title: Denoise??
Post by: LM6 on June 23, 2020, 02:10:09 AM
Not sure if iam doing something wrong but in GPU mode Denoise is not being applied to the render.
Ive attached 2 renders so you can what i mean, one is a view port screen grab and the other from a render.

Using 4 x 2080 ti
Iam taking the screen grab after about 1 min which is about 6000 samples so that's what i set the render to.
Title: Re: Denoise??
Post by: DriesV on June 23, 2020, 03:50:45 AM
Hi Peter,

That seems strange.
What version of KeyShot are you running?
Note that the offline rendering is using a CPU denoiser (Intel Open Image Denoise), so it should work regardless of GPU Mode.

Dries
Title: Re: Denoise??
Post by: LM6 on June 23, 2020, 05:43:24 AM
Hello Dries..

Iam using 9.3.14
Nvidia 442.92

Peter
Title: Re: Denoise??
Post by: DriesV on June 23, 2020, 07:12:01 AM
Any chance you can share the scene?

Dries
Title: Re: Denoise??
Post by: LM6 on June 23, 2020, 08:06:18 AM
Not that one , i will try and re create with simple scene
Title: Re: Denoise??
Post by: LM6 on June 23, 2020, 08:18:52 AM
Here is a test scene will similar lighting, seems to be the ground illumination  that's causing the problem.
Title: Re: Denoise??
Post by: joseph on June 26, 2020, 09:57:52 PM
Hi. I gave it a try.
abstract.060 60 sec screen shot
abstract.1436 14:36 cpu rendering
3700X with 32 GB
5500XT 8GDDR6
Title: Re: Denoise??
Post by: LM6 on June 27, 2020, 03:53:10 AM
Hi Joseph

If i use CPU as you have, the 2 images look very similar as yours do but:

Screen grab: It takes 60 seconds to get to around 900 samples in the view port
Render: 900 samples takes about 46 seconds (was yours really 14 seconds)

My CPU: 2990 WX

What samples are you getting on your renders?

On this scene iam not noticing any difference between Denoise and no Denoise on the renders


Title: Re: Denoise??
Post by: joseph on June 27, 2020, 04:58:21 AM
It is 405 samples on  60 sec. and 6000 samples on the render on file 14 mins 36 sec.
I have attached the current benchmark product by Magnus Skogsfjord
So Denoise works with AMD 5500XT gpu and cycles with idle for five seconds and denoise 1 second. The Denoise slider is maxed at 1, and can't type more than that.
Title: Re: Denoise??
Post by: Radace on June 28, 2020, 09:00:53 AM
I geto same problem even made topic about that with simple file... https://forum.keyshot.com/index.php?topic=26460.0
denoise not working when I put camera into scattering medium object, when camera is outside denoise is working on gpu

@Josept stop it, we talking about GPU mode on nvidia cards, ur post are useless....

Someone can tell me how to fix that denoise???
Title: Re: Denoise??
Post by: LM6 on June 29, 2020, 03:36:36 AM
@Dries did you get a chance to check out the scene I posted?

Cheers

Peter
Title: Re: Denoise??
Post by: DriesV on June 29, 2020, 06:10:03 AM
Hi Peter,

Yes, I did check it out this morning. Thank you for sharing.

As I mentioned earlier, the offline rendering is using a CPU denoiser (Intel Open Image Denoise) for both CPU and GPU rendering, while the Real-time View with GPU Mode is using the NVIDIA OptiX Denoiser.
It turns out that, for some reason, the Intel denoiser doesn't do a good job of removing this particular noise. We are a bit surprised by this as well, as it seems like an ideal scenario for any denoiser.

Dries
Title: Re: Denoise??
Post by: LM6 on June 29, 2020, 07:46:28 AM
Hi Dries..

Thanks for the info, that explains it perfectly.

Peter
Title: Re: Denoise??
Post by: Radace on June 29, 2020, 10:38:47 AM
And how to fix it?
Title: Re: Denoise??
Post by: DriesV on June 29, 2020, 12:17:18 PM
Quote from: Radace on June 29, 2020, 10:38:47 AM
And how to fix it?

The issue occurs in areas of the image that internally are transparent (alpha of 0). This includes: ground shadows, ground illumination and DOF against the environment background.
A solution is to put some geometry below or a around your object as a background.
We are looking into making the Intel denoiser not take alpha into account. No ETA on a fix yet.

Dries
Title: Re: Denoise??
Post by: Radace on June 29, 2020, 04:26:51 PM
DriesV, I got different problem, in my other post, denoiser cannot apply on volumeric fog (scattering medium fog) when camera is inside object with fog + some area lights

Post and files:
https://forum.keyshot.com/index.php?topic=26460.0
Title: Re: Denoise??
Post by: DriesV on June 30, 2020, 02:04:38 AM
Hi Radace,

That is essentially the same issue, just presented differently. :)
Your scene did reveal another issue though. It appears Scattering Medium has different transparency (under the hood) for CPU and GPU when the camera is inside the medium. This has been filed as a bug.

Dries
Title: Re: Denoise??
Post by: Radace on June 30, 2020, 03:21:30 AM
Thank you for answer, im working on animation with city and camera going through fog (with light and other fx's) problem is huge :(

any info when this bug can be fixed?
Title: Re: Denoise??
Post by: DriesV on June 30, 2020, 04:29:52 AM
This issue won't likely be fixed before the release of KeyShot 10.

As a workaround, you can use external command line denoiser tools to denoise the output images from KeyShot.
Declan Russell has been kind enough to make Windows builds of both the Intel Open Image and NVIDIA OptiX denoisers.

Intel Open Image Denoiser
Overview (https://declanrussell.com/portfolio/intel-open-image-denoiser-2/)
Download (https://github.com/DeclanRussell/IntelOIDenoiser/releases/download/1.3/Denoiser_v1.3.zip)
Instructions for use (GitHub) (https://github.com/DeclanRussell/IntelOIDenoiser/blob/master/README.md)

NVIDIA OptiX Denoiser
Overview (https://declanrussell.com/portfolio/nvidia-ai-denoiser/)
Download (https://github.com/DeclanRussell/NvidiaAIDenoiser/releases/download/2.4/Denoiser_v2.4.zip)
Instructions for use (GitHub) (https://github.com/DeclanRussell/NvidiaAIDenoiser/blob/master/README.md)

The Intel denoiser runs on CPU, while the OptiX denoiser requires an NVIDIA GPU (Driver version 436.02 or newer, GPU of Maxwell architecture or newer).

Both overviews on GitHub contain an example for a batch script. So it should work for animation frame sequences as well.
I hope this helps.

Dries
Title: Re: Denoise??
Post by: Radace on June 30, 2020, 06:13:12 AM
Is some tutorial how to use it with keyshot? Im pretty newby in this? :O
Title: Re: Denoise??
Post by: DriesV on June 30, 2020, 06:44:36 AM
The Intel and OptiX denoisers are operated very similarly via command line.

The simplest tutorial would be:

You can further experiment with the other arguments (e.g. feed diffuse and normal passes) to see if you get better results that way.

Dries
Title: Re: Denoise??
Post by: DriesV on June 30, 2020, 07:12:47 AM
The tools seem to work pretty well.
Here is a noisy input image, and the denoised result from both the Intel and OptiX denoiser.

Dries
Title: Re: Denoise??
Post by: Radace on June 30, 2020, 07:24:46 AM
WOW thank you it works, but how to make it to denoise multiple files at once?
Title: Re: Denoise??
Post by: DriesV on June 30, 2020, 09:03:13 AM
Quote from: Radace on June 30, 2020, 07:24:46 AM
WOW thank you it works, but how to make it to denoise multiple files at once?

You can use the 'Simple sequence batch script' for that.
See here (https://github.com/DeclanRussell/IntelOIDenoiser/blob/master/README.md#simple-sequence-batch-script).

Dries